forgejo/templates/repo
sillyguodong bfecf3bd89
Fix internal sever error when visiting a PR that bound to the deleted team (#24127)
Close: #23738

The actual cause of `500 Internal Server Error` in the issue is not what
is descirbed in the issue.

The actual cause is that after deleting team, if there is a PR which has
requested reivew from the deleted team, the comment could not match with
the deleted team by `assgin_team_id`. So the value of `.AssigneeTeam`
(see below code block) is `nil` which cause `500 error`.


1c8bc4081a/templates/repo/issue/view_content/comments.tmpl (L691-L695)

To fix this bug, there are the following problems to be resolved:

- [x] 1. ~~Stroe the name of the team in `content` column when inserting
`comment` into DB in case that we cannot get the name of team after it
is deleted. But for comments that already exist, just display "Unknown
Team"~~ Just display "Ghost Team" in the comment if the assgined team is
deleted.
- [x] 2. Delete the PR&team binding (the row of which `review_team_id =
${team_id} ` in table `review`) when deleting team.
- [x] 3.For already exist and undeleted binding rows in in table
`review`, ~~we can delete these rows when executing migrations.~~ they
do not affect the function, so won't delete them.
2023-04-19 19:50:00 -04:00
..
actions Add runner check in repo action page (#24124) 2023-04-19 20:51:20 +08:00
branch Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
cite Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
diff Expand/Collapse all changed files (#23639) 2023-04-09 21:11:02 +08:00
editor Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
find Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
graph Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
issue Fix internal sever error when visiting a PR that bound to the deleted team (#24127) 2023-04-19 19:50:00 -04:00
migrate Group template helper functions, remove Printf, improve template error messages (#23982) 2023-04-08 21:15:22 +08:00
projects Add unset default project column (#23531) 2023-04-19 10:28:28 -04:00
pulls Discolor pull request tab labels (#23950) 2023-04-07 15:12:45 -04:00
release Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
settings Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
wiki Make wiki title supports dashes and improve wiki name related features (#24143) 2023-04-19 13:50:10 -04:00
activity.tmpl Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
blame.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
branch_dropdown.tmpl Refactor branch/tag selector to Vue SFC (#23421) 2023-03-14 17:51:20 +08:00
clone_buttons.tmpl Clean template/helper.go (#23922) 2023-04-07 03:31:41 -04:00
clone_script.tmpl Clean template/helper.go (#23922) 2023-04-07 03:31:41 -04:00
commit_page.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
commit_status.tmpl Use different SVG for pending and running actions (#23836) 2023-03-31 17:24:39 +08:00
commit_statuses.tmpl Fix hidden commit status on multiple checks (#22889) 2023-02-20 16:43:04 +08:00
commits.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
commits_list.tmpl Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
commits_list_small.tmpl Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
commits_table.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
create.tmpl Make label templates have consistent behavior and priority (#23749) 2023-04-10 16:44:02 +08:00
create_helper.tmpl Add templates to customize text when creating and migrating repositories 2023-01-24 22:36:48 -05:00
empty.tmpl Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
file_info.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
forks.tmpl Remove fomantic ".link" selector and styles (#23888) 2023-04-03 20:47:23 -04:00
graph.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
header.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
home.tmpl Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
icon.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
packages.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
search.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
search_name.tmpl Clean template/helper.go (#23922) 2023-04-07 03:31:41 -04:00
shabox_badge.tmpl Fix shabox regression (#22924) 2023-02-16 09:37:11 +08:00
sub_menu.tmpl Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
unicode_escape_prompt.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
upload.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
user_cards.tmpl Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
view_file.tmpl Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
view_list.tmpl Add wrapper to author to avoid long name ui problem (#23030) 2023-02-23 14:28:18 -06:00
watchers.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00