forgejo/templates
sillyguodong bfecf3bd89
Fix internal sever error when visiting a PR that bound to the deleted team (#24127)
Close: #23738

The actual cause of `500 Internal Server Error` in the issue is not what
is descirbed in the issue.

The actual cause is that after deleting team, if there is a PR which has
requested reivew from the deleted team, the comment could not match with
the deleted team by `assgin_team_id`. So the value of `.AssigneeTeam`
(see below code block) is `nil` which cause `500 error`.


1c8bc4081a/templates/repo/issue/view_content/comments.tmpl (L691-L695)

To fix this bug, there are the following problems to be resolved:

- [x] 1. ~~Stroe the name of the team in `content` column when inserting
`comment` into DB in case that we cannot get the name of team after it
is deleted. But for comments that already exist, just display "Unknown
Team"~~ Just display "Ghost Team" in the comment if the assgined team is
deleted.
- [x] 2. Delete the PR&team binding (the row of which `review_team_id =
${team_id} ` in table `review`) when deleting team.
- [x] 3.For already exist and undeleted binding rows in in table
`review`, ~~we can delete these rows when executing migrations.~~ they
do not affect the function, so won't delete them.
2023-04-19 19:50:00 -04:00
..
admin Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base Show friendly 500 error page to users and developers (#24110) 2023-04-14 13:19:11 +08:00
code Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
devtest Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
explore Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
mail Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
org Add repository counter badge to repository tab (#24205) 2023-04-19 14:58:36 -04:00
package Remove untranslatable on_date key (#24106) 2023-04-15 13:01:54 +02:00
projects Add unset default project column (#23531) 2023-04-19 10:28:28 -04:00
repo Fix internal sever error when visiting a PR that bound to the deleted team (#24127) 2023-04-19 19:50:00 -04:00
shared Add monospace toggle button to textarea (#24034) 2023-04-13 15:05:06 -04:00
status Show friendly 500 error page to users and developers (#24110) 2023-04-14 13:19:11 +08:00
swagger Add activity feeds API (#23494) 2023-04-04 21:35:31 +08:00
user Add repository counter badge to repository tab (#24205) 2023-04-19 14:58:36 -04:00
home.tmpl Improve home page template, fix Sort dropdown menu flash (#23856) 2023-04-01 13:47:54 +08:00
install.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
post-install.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00