forgejo/services
zeripath d6fa138e7c
Only send webhook events to active system webhooks and only deliver to active hooks (#19234)
There is a bug in the system webhooks whereby the active state is not checked when
webhooks are prepared and there is a bug that deactivating webhooks do not prevent
queued deliveries.

* Only add SystemWebhooks to the prepareWebhooks list if they are active
* At the time of delivery if the underlying webhook is not active mark it
as "delivered" but with a failed delivery so it does not get delivered.

Fix #19220

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-03-28 11:17:21 +08:00
..
agit Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
asymkey Use ctx instead of db.DefaultContext in some packages(routers/services/modules) (#19163) 2022-03-22 16:22:54 +01:00
attachment Simplify parameter types (#18006) 2021-12-20 04:41:31 +00:00
auth Update HTTP status codes to modern codes (#18063) 2022-03-23 12:54:07 +08:00
comments format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
context Add ContextUser to http request context (#18798) 2022-03-26 17:04:22 +08:00
cron Make cron task no notice on success (#19221) 2022-03-26 21:13:04 +00:00
externalaccount Refactor auth package (#17962) 2022-01-02 21:12:35 +08:00
forms Add config option to disable "Update branch by rebase" (#18745) 2022-03-04 03:30:49 -05:00
gitdiff rm .sample hooks which aren't used (#19101) 2022-03-16 10:33:07 +00:00
issue Allow users to self-request a PR review (#19030) 2022-03-08 22:48:47 +01:00
lfs Update HTTP status codes to modern codes (#18063) 2022-03-23 12:54:07 +08:00
mailer Try to prevent autolinking of displaynames by email readers (#19169) 2022-03-23 12:34:20 +00:00
migrations Update HTTP status codes to modern codes (#18063) 2022-03-23 12:54:07 +08:00
mirror Touch mirrors on even on fail to update (#19217) 2022-03-27 15:40:17 +01:00
org Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
pull Use ctx instead of db.DefaultContext in some packages(routers/services/modules) (#19163) 2022-03-22 16:22:54 +01:00
release Use ctx instead of db.DefaultContext in some packages(routers/services/modules) (#19163) 2022-03-22 16:22:54 +01:00
repository Fix compare link in active feeds for new branch (#19149) 2022-03-23 13:40:12 +00:00
task Pause queues (#15928) 2022-01-22 21:22:14 +00:00
user Use ctx instead of db.DefaultContext in some packages(routers/services/modules) (#19163) 2022-03-22 16:22:54 +01:00
webhook Only send webhook events to active system webhooks and only deliver to active hooks (#19234) 2022-03-28 11:17:21 +08:00
wiki Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00