forgejo/routers
Eng Zer Jun 8b0aaa5f86
test: use T.TempDir to create temporary test directory (#21043)
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
api Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
common Rework raw file http header logic (#20484) 2022-07-29 17:26:55 +02:00
install Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
private Add migrate repo archiver and packages storage support on command line (#20757) 2022-08-16 12:05:15 +08:00
utils refactor webhook *NewPost (#20729) 2022-08-11 17:48:23 +02:00
web test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
init.go Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00