forgejo/services
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
agit Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
asymkey Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
attachment Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
auth SessionUser protection against nil pointer dereference (#21358) 2022-10-06 21:50:38 +01:00
automerge Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
comments Move issues related files into models/issues (#19931) 2022-06-13 17:37:59 +08:00
context Move almost all functions' parameter db.Engine to context.Context (#19748) 2022-05-20 22:08:52 +08:00
cron Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
externalaccount Refactor auth package (#17962) 2022-01-02 21:12:35 +08:00
forms Limit length of repo description and repo url input fields (#21119) 2022-09-16 15:19:16 +08:00
gitdiff Stop logging CheckPath returns error: context canceled (#21064) 2022-10-10 21:54:30 +01:00
issue Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
lfs Move some code into models/git (#19879) 2022-06-12 23:51:54 +08:00
mailer Add generic set type (#21408) 2022-10-12 13:18:26 +08:00
migrations Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
mirror Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
org Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
packages Replace ServeStream with ServeContent (#20903) 2022-08-25 12:05:21 -04:00
pull Add generic set type (#21408) 2022-10-12 13:18:26 +08:00
release Do not send notifications for draft releases (#21451) 2022-10-17 17:33:27 -04:00
repository Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
task Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
user Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
webhook Display total commit count in hook message (#21400) 2022-10-17 00:22:34 +08:00
wiki Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00