forgejo/services/forms
Zettat123 9a83aa28a3
Get rules by id when editing branch protection rule (#22932)
When users rename an existing branch protection rule, a new rule with
the new name will be created and the old rule will still exist.

![image](https://user-images.githubusercontent.com/15528715/219276442-d3c001ad-e693-44ec-9ad2-b33f2666b49b.png)

---

![image](https://user-images.githubusercontent.com/15528715/219276478-547c3b93-b3f1-4292-a1ef-c1b7747fe1bb.png)

The reason is that the `SettingsProtectedBranchPost` function only get
branch protection rule by name before updating or creating a rule. When
the rule name changes, the function cannot find the existing rule so it
will create a new rule rather than update the existing rule. To fix the
bug, the function should get rule by id first.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-20 19:30:41 +08:00
..
admin.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth_form.go Map OIDC groups to Orgs/Teams (#21441) 2023-02-08 14:44:42 +08:00
org.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
package_form.go Add Chef package registry (#22554) 2023-02-06 09:49:21 +08:00
repo_branch_form.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_form.go Get rules by id when editing branch protection rule (#22932) 2023-02-20 19:30:41 +08:00
repo_form_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_tag_form.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
runner.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
user_form.go Support scoped access tokens (#20908) 2023-01-17 15:46:03 -06:00
user_form_auth_openid.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user_form_hidden_comments.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user_form_test.go Support scoped access tokens (#20908) 2023-01-17 15:46:03 -06:00