From f9894f4c5147447fa2f38a1835a575fd38f54e75 Mon Sep 17 00:00:00 2001 From: Gergely Nagy Date: Mon, 4 Mar 2024 08:25:07 +0100 Subject: [PATCH] A release title should always be a link This partially reverts c41b2c73ef21d5c54c7f2658ceffaa163b135131: for the sake of consistency, the title of a release should always be a link, whether it's a tag-only release or not. Signed-off-by: Gergely Nagy --- templates/repo/release/list.tmpl | 2 +- tests/integration/repo_tag_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/repo/release/list.tmpl b/templates/repo/release/list.tmpl index 826480e3fb..d533cf6757 100644 --- a/templates/repo/release/list.tmpl +++ b/templates/repo/release/list.tmpl @@ -18,7 +18,7 @@

- {{if $.PageIsSingleTag}}{{$release.Title}}{{else}}{{$release.Title}}{{end}} + {{$release.Title}} {{template "repo/commit_statuses" dict "Status" $info.CommitStatus "Statuses" $info.CommitStatuses "AdditionalClasses" "gt-df"}} {{if $release.IsDraft}} {{ctx.Locale.Tr "repo.release.draft"}} diff --git a/tests/integration/repo_tag_test.go b/tests/integration/repo_tag_test.go index 5a99453659..3fa3454343 100644 --- a/tests/integration/repo_tag_test.go +++ b/tests/integration/repo_tag_test.go @@ -59,7 +59,7 @@ func TestTagViewWithoutRelease(t *testing.T) { assert.False(t, releaseLink.HasClass("active")) // Test that the title is displayed - releaseTitle := strings.TrimSpace(htmlDoc.Find("h4.release-list-title").Text()) + releaseTitle := strings.TrimSpace(htmlDoc.Find("h4.release-list-title > a").Text()) assert.Equal(t, "no-release", releaseTitle) // Test that there is no "Stable" link