2019-09-30 13:50:44 +00:00
|
|
|
// Copyright 2019 The Gitea Authors. All rights reserved.
|
2022-11-27 18:20:29 +00:00
|
|
|
// SPDX-License-Identifier: MIT
|
2019-09-30 13:50:44 +00:00
|
|
|
|
|
|
|
package issue
|
|
|
|
|
|
|
|
import (
|
2023-04-14 18:18:28 +00:00
|
|
|
"context"
|
2022-03-01 00:20:15 +00:00
|
|
|
"fmt"
|
[FEAT] allow setting the update date on issues and comments
This field adds the possibility to set the update date when modifying
an issue through the API.
A 'NoAutoDate' in-memory field is added in the Issue struct.
If the update_at field is set, NoAutoDate is set to true and the
Issue's UpdatedUnix field is filled.
That information is passed down to the functions that actually updates
the database, which have been modified to not auto update dates if
requested.
A guard is added to the 'EditIssue' API call, to checks that the
udpate_at date is between the issue's creation date and the current
date (to avoid 'malicious' changes). It also limits the new feature
to project's owners and admins.
(cherry picked from commit c524d33402c76bc4cccea2806f289e08a009baae)
Add a SetIssueUpdateDate() function in services/issue.go
That function is used by some API calls to set the NoAutoDate and
UpdatedUnix fields of an Issue if an updated_at date is provided.
(cherry picked from commit f061caa6555e0c9e922ee1e73dd2e4337360e9fe)
Add an updated_at field to the API calls related to Issue's Labels.
The update date is applied to the issue's comment created to inform
about the modification of the issue's labels.
(cherry picked from commit ea36cf80f58f0ab20c565a8f5d063b90fd741f97)
Add an updated_at field to the API call for issue's attachment creation
The update date is applied to the issue's comment created to inform
about the modification of the issue's content, and is set as the
asset creation date.
(cherry picked from commit 96150971ca31b97e97e84d5f5eb95a177cc44e2e)
Checking Issue changes, with and without providing an updated_at date
Those unit tests are added:
- TestAPIEditIssueWithAutoDate
- TestAPIEditIssueWithNoAutoDate
- TestAPIAddIssueLabelsWithAutoDate
- TestAPIAddIssueLabelsWithNoAutoDate
- TestAPICreateIssueAttachmentWithAutoDate
- TestAPICreateIssueAttachmentWithNoAutoDate
(cherry picked from commit 4926a5d7a28581003545256632213bf4136b193d)
Add an updated_at field to the API call for issue's comment creation
The update date is used as the comment creation date, and is applied to
the issue as the update creation date.
(cherry picked from commit 76c8faecdc6cba48ca4fe07d1a916d1f1a4b37b4)
Add an updated_at field to the API call for issue's comment edition
The update date is used as the comment update date, and is applied to
the issue as an update date.
(cherry picked from commit cf787ad7fdb8e6273fdc35d7b5cc164b400207e9)
Add an updated_at field to the API call for comment's attachment creation
The update date is applied to the comment, and is set as the asset
creation date.
(cherry picked from commit 1e4ff424d39db7a4256cd9abf9c58b8d3e1b5c14)
Checking Comment changes, with and without providing an updated_at date
Those unit tests are added:
- TestAPICreateCommentWithAutoDate
- TestAPICreateCommentWithNoAutoDate
- TestAPIEditCommentWithAutoDate
- TestAPIEditCommentWithNoAutoDate
- TestAPICreateCommentAttachmentWithAutoDate
- TestAPICreateCommentAttachmentWithNoAutoDate
(cherry picked from commit da932152f1deb3039a399516a51c8b6757059c91)
Pettier code to set the update time of comments
Now uses sess.AllCols().NoAutoToime().SetExpr("updated_unix", ...)
XORM is smart enough to compose one single SQL UPDATE which all
columns + updated_unix.
(cherry picked from commit 1f6a42808dd739c0c2e49e6b7ae2967f120f43c2)
Issue edition: Keep the max of the milestone and issue update dates.
When editing an issue via the API, an updated_at date can be provided.
If the EditIssue call changes the issue's milestone, the milestone's
update date is to be changed accordingly, but only with a greater
value.
This ensures that a milestone's update date is the max of all issue's
update dates.
(cherry picked from commit 8f22ea182e6b49e933dc6534040160dd739ff18a)
Rewrite the 'AutoDate' tests using subtests
Also add a test to check the permissions to set a date, and a test
to check update dates on milestones.
The tests related to 'AutoDate' are:
- TestAPIEditIssueAutoDate
- TestAPIAddIssueLabelsAutoDate
- TestAPIEditIssueMilestoneAutoDate
- TestAPICreateIssueAttachmentAutoDate
- TestAPICreateCommentAutoDate
- TestAPIEditCommentWithDate
- TestAPICreateCommentAttachmentAutoDate
(cherry picked from commit 961fd13c551b3e50040acb7c914a00ead92de63f)
2023-05-30 16:42:58 +00:00
|
|
|
"time"
|
2022-03-01 00:20:15 +00:00
|
|
|
|
2022-08-25 02:31:57 +00:00
|
|
|
activities_model "code.gitea.io/gitea/models/activities"
|
2021-09-19 11:49:59 +00:00
|
|
|
"code.gitea.io/gitea/models/db"
|
2022-06-13 09:37:59 +00:00
|
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
2022-05-11 10:09:36 +00:00
|
|
|
access_model "code.gitea.io/gitea/models/perm/access"
|
2022-06-13 09:37:59 +00:00
|
|
|
project_model "code.gitea.io/gitea/models/project"
|
2021-12-10 01:27:50 +00:00
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
2022-10-16 23:29:26 +00:00
|
|
|
system_model "code.gitea.io/gitea/models/system"
|
2021-11-24 09:49:20 +00:00
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
2020-05-14 22:55:43 +00:00
|
|
|
"code.gitea.io/gitea/modules/git"
|
2019-10-25 14:46:37 +00:00
|
|
|
"code.gitea.io/gitea/modules/notification"
|
2022-06-13 09:37:59 +00:00
|
|
|
"code.gitea.io/gitea/modules/storage"
|
[FEAT] allow setting the update date on issues and comments
This field adds the possibility to set the update date when modifying
an issue through the API.
A 'NoAutoDate' in-memory field is added in the Issue struct.
If the update_at field is set, NoAutoDate is set to true and the
Issue's UpdatedUnix field is filled.
That information is passed down to the functions that actually updates
the database, which have been modified to not auto update dates if
requested.
A guard is added to the 'EditIssue' API call, to checks that the
udpate_at date is between the issue's creation date and the current
date (to avoid 'malicious' changes). It also limits the new feature
to project's owners and admins.
(cherry picked from commit c524d33402c76bc4cccea2806f289e08a009baae)
Add a SetIssueUpdateDate() function in services/issue.go
That function is used by some API calls to set the NoAutoDate and
UpdatedUnix fields of an Issue if an updated_at date is provided.
(cherry picked from commit f061caa6555e0c9e922ee1e73dd2e4337360e9fe)
Add an updated_at field to the API calls related to Issue's Labels.
The update date is applied to the issue's comment created to inform
about the modification of the issue's labels.
(cherry picked from commit ea36cf80f58f0ab20c565a8f5d063b90fd741f97)
Add an updated_at field to the API call for issue's attachment creation
The update date is applied to the issue's comment created to inform
about the modification of the issue's content, and is set as the
asset creation date.
(cherry picked from commit 96150971ca31b97e97e84d5f5eb95a177cc44e2e)
Checking Issue changes, with and without providing an updated_at date
Those unit tests are added:
- TestAPIEditIssueWithAutoDate
- TestAPIEditIssueWithNoAutoDate
- TestAPIAddIssueLabelsWithAutoDate
- TestAPIAddIssueLabelsWithNoAutoDate
- TestAPICreateIssueAttachmentWithAutoDate
- TestAPICreateIssueAttachmentWithNoAutoDate
(cherry picked from commit 4926a5d7a28581003545256632213bf4136b193d)
Add an updated_at field to the API call for issue's comment creation
The update date is used as the comment creation date, and is applied to
the issue as the update creation date.
(cherry picked from commit 76c8faecdc6cba48ca4fe07d1a916d1f1a4b37b4)
Add an updated_at field to the API call for issue's comment edition
The update date is used as the comment update date, and is applied to
the issue as an update date.
(cherry picked from commit cf787ad7fdb8e6273fdc35d7b5cc164b400207e9)
Add an updated_at field to the API call for comment's attachment creation
The update date is applied to the comment, and is set as the asset
creation date.
(cherry picked from commit 1e4ff424d39db7a4256cd9abf9c58b8d3e1b5c14)
Checking Comment changes, with and without providing an updated_at date
Those unit tests are added:
- TestAPICreateCommentWithAutoDate
- TestAPICreateCommentWithNoAutoDate
- TestAPIEditCommentWithAutoDate
- TestAPIEditCommentWithNoAutoDate
- TestAPICreateCommentAttachmentWithAutoDate
- TestAPICreateCommentAttachmentWithNoAutoDate
(cherry picked from commit da932152f1deb3039a399516a51c8b6757059c91)
Pettier code to set the update time of comments
Now uses sess.AllCols().NoAutoToime().SetExpr("updated_unix", ...)
XORM is smart enough to compose one single SQL UPDATE which all
columns + updated_unix.
(cherry picked from commit 1f6a42808dd739c0c2e49e6b7ae2967f120f43c2)
Issue edition: Keep the max of the milestone and issue update dates.
When editing an issue via the API, an updated_at date can be provided.
If the EditIssue call changes the issue's milestone, the milestone's
update date is to be changed accordingly, but only with a greater
value.
This ensures that a milestone's update date is the max of all issue's
update dates.
(cherry picked from commit 8f22ea182e6b49e933dc6534040160dd739ff18a)
Rewrite the 'AutoDate' tests using subtests
Also add a test to check the permissions to set a date, and a test
to check update dates on milestones.
The tests related to 'AutoDate' are:
- TestAPIEditIssueAutoDate
- TestAPIAddIssueLabelsAutoDate
- TestAPIEditIssueMilestoneAutoDate
- TestAPICreateIssueAttachmentAutoDate
- TestAPICreateCommentAutoDate
- TestAPIEditCommentWithDate
- TestAPICreateCommentAttachmentAutoDate
(cherry picked from commit 961fd13c551b3e50040acb7c914a00ead92de63f)
2023-05-30 16:42:58 +00:00
|
|
|
"code.gitea.io/gitea/modules/timeutil"
|
2019-09-30 13:50:44 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
// NewIssue creates new issue with labels for repository.
|
2023-04-14 18:18:28 +00:00
|
|
|
func NewIssue(ctx context.Context, repo *repo_model.Repository, issue *issues_model.Issue, labelIDs []int64, uuids []string, assigneeIDs []int64) error {
|
2023-08-14 23:07:38 +00:00
|
|
|
// Check if the user is not blocked by the repo's owner.
|
|
|
|
if user_model.IsBlocked(ctx, repo.OwnerID, issue.PosterID) {
|
|
|
|
return user_model.ErrBlockedByUser
|
|
|
|
}
|
|
|
|
|
2022-06-13 09:37:59 +00:00
|
|
|
if err := issues_model.NewIssue(repo, issue, labelIDs, uuids); err != nil {
|
2019-09-30 13:50:44 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2019-10-28 16:45:43 +00:00
|
|
|
for _, assigneeID := range assigneeIDs {
|
2023-08-10 02:39:21 +00:00
|
|
|
if _, err := AddAssigneeIfNotAssigned(ctx, issue, issue.Poster, assigneeID, true); err != nil {
|
2019-10-28 16:45:43 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-04-14 18:18:28 +00:00
|
|
|
mentions, err := issues_model.FindAndUpdateIssueMentions(ctx, issue, issue.Poster, issue.Content)
|
2021-01-02 17:04:02 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2023-04-14 18:18:28 +00:00
|
|
|
notification.NotifyNewIssue(ctx, issue, mentions)
|
2021-01-17 14:15:57 +00:00
|
|
|
if len(issue.Labels) > 0 {
|
2023-04-14 18:18:28 +00:00
|
|
|
notification.NotifyIssueChangeLabels(ctx, issue.Poster, issue, issue.Labels, nil)
|
2021-01-17 14:15:57 +00:00
|
|
|
}
|
|
|
|
if issue.Milestone != nil {
|
2023-04-14 18:18:28 +00:00
|
|
|
notification.NotifyIssueChangeMilestone(ctx, issue.Poster, issue, 0)
|
2021-01-17 14:15:57 +00:00
|
|
|
}
|
2019-09-30 13:50:44 +00:00
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
2019-10-11 06:44:43 +00:00
|
|
|
|
|
|
|
// ChangeTitle changes the title of this issue, as the given user.
|
2023-07-07 05:31:56 +00:00
|
|
|
func ChangeTitle(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, title string) error {
|
2019-10-11 06:44:43 +00:00
|
|
|
oldTitle := issue.Title
|
|
|
|
issue.Title = title
|
|
|
|
|
2023-07-07 05:31:56 +00:00
|
|
|
if err := issues_model.ChangeIssueTitle(ctx, issue, doer, oldTitle); err != nil {
|
|
|
|
return err
|
2019-10-11 06:44:43 +00:00
|
|
|
}
|
|
|
|
|
2023-06-08 08:56:05 +00:00
|
|
|
if issue.IsPull && issues_model.HasWorkInProgressPrefix(oldTitle) && !issues_model.HasWorkInProgressPrefix(title) {
|
2023-07-07 05:31:56 +00:00
|
|
|
if err := issues_model.PullRequestCodeOwnersReview(ctx, issue, issue.PullRequest); err != nil {
|
|
|
|
return err
|
2023-06-08 08:56:05 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-04-14 18:18:28 +00:00
|
|
|
notification.NotifyIssueChangeTitle(ctx, doer, issue, oldTitle)
|
2019-10-11 06:44:43 +00:00
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
2019-10-25 14:46:37 +00:00
|
|
|
|
2020-09-08 16:29:51 +00:00
|
|
|
// ChangeIssueRef changes the branch of this issue, as the given user.
|
2023-04-14 18:18:28 +00:00
|
|
|
func ChangeIssueRef(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, ref string) error {
|
2020-09-08 16:29:51 +00:00
|
|
|
oldRef := issue.Ref
|
|
|
|
issue.Ref = ref
|
|
|
|
|
2022-06-13 09:37:59 +00:00
|
|
|
if err := issues_model.ChangeIssueRef(issue, doer, oldRef); err != nil {
|
2020-09-08 16:29:51 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2023-04-14 18:18:28 +00:00
|
|
|
notification.NotifyIssueChangeRef(ctx, doer, issue, oldRef)
|
2020-09-08 16:29:51 +00:00
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-10-25 14:46:37 +00:00
|
|
|
// UpdateAssignees is a helper function to add or delete one or multiple issue assignee(s)
|
|
|
|
// Deleting is done the GitHub way (quote from their api documentation):
|
|
|
|
// https://developer.github.com/v3/issues/#edit-an-issue
|
|
|
|
// "assignees" (array): Logins for Users to assign to this issue.
|
|
|
|
// Pass one or more user logins to replace the set of assignees on this Issue.
|
|
|
|
// Send an empty array ([]) to clear all assignees from the Issue.
|
2023-04-14 18:18:28 +00:00
|
|
|
func UpdateAssignees(ctx context.Context, issue *issues_model.Issue, oneAssignee string, multipleAssignees []string, doer *user_model.User) (err error) {
|
2021-11-24 09:49:20 +00:00
|
|
|
var allNewAssignees []*user_model.User
|
2019-10-25 14:46:37 +00:00
|
|
|
|
|
|
|
// Keep the old assignee thingy for compatibility reasons
|
|
|
|
if oneAssignee != "" {
|
|
|
|
// Prevent double adding assignees
|
|
|
|
var isDouble bool
|
|
|
|
for _, assignee := range multipleAssignees {
|
|
|
|
if assignee == oneAssignee {
|
|
|
|
isDouble = true
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if !isDouble {
|
|
|
|
multipleAssignees = append(multipleAssignees, oneAssignee)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Loop through all assignees to add them
|
|
|
|
for _, assigneeName := range multipleAssignees {
|
2023-04-14 18:18:28 +00:00
|
|
|
assignee, err := user_model.GetUserByName(ctx, assigneeName)
|
2019-10-25 14:46:37 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
allNewAssignees = append(allNewAssignees, assignee)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Delete all old assignees not passed
|
2023-04-14 18:18:28 +00:00
|
|
|
if err = DeleteNotPassedAssignee(ctx, issue, doer, allNewAssignees); err != nil {
|
2019-10-25 14:46:37 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add all new assignees
|
|
|
|
// Update the assignee. The function will check if the user exists, is already
|
|
|
|
// assigned (which he shouldn't as we deleted all assignees before) and
|
|
|
|
// has access to the repo.
|
|
|
|
for _, assignee := range allNewAssignees {
|
|
|
|
// Extra method to prevent double adding (which would result in removing)
|
2023-08-10 02:39:21 +00:00
|
|
|
_, err = AddAssigneeIfNotAssigned(ctx, issue, doer, assignee.ID, true)
|
2019-10-25 14:46:37 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-06-20 10:02:49 +00:00
|
|
|
return err
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
|
|
|
|
2022-03-01 00:20:15 +00:00
|
|
|
// DeleteIssue deletes an issue
|
2023-04-14 18:18:28 +00:00
|
|
|
func DeleteIssue(ctx context.Context, doer *user_model.User, gitRepo *git.Repository, issue *issues_model.Issue) error {
|
2022-03-01 00:20:15 +00:00
|
|
|
// load issue before deleting it
|
2023-04-14 18:18:28 +00:00
|
|
|
if err := issue.LoadAttributes(ctx); err != nil {
|
2022-03-01 00:20:15 +00:00
|
|
|
return err
|
|
|
|
}
|
2023-04-14 18:18:28 +00:00
|
|
|
if err := issue.LoadPullRequest(ctx); err != nil {
|
2022-03-01 00:20:15 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// delete entries in database
|
2023-04-14 18:18:28 +00:00
|
|
|
if err := deleteIssue(ctx, issue); err != nil {
|
2022-03-01 00:20:15 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// delete pull request related git data
|
2023-04-14 18:18:28 +00:00
|
|
|
if issue.IsPull && gitRepo != nil {
|
2022-06-19 10:05:15 +00:00
|
|
|
if err := gitRepo.RemoveReference(fmt.Sprintf("%s%d/head", git.PullPrefix, issue.PullRequest.Index)); err != nil {
|
2022-03-01 00:20:15 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-05-25 13:17:19 +00:00
|
|
|
// If the Issue is pinned, we should unpin it before deletion to avoid problems with other pinned Issues
|
|
|
|
if issue.IsPinned() {
|
|
|
|
if err := issue.Unpin(ctx, doer); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-04-14 18:18:28 +00:00
|
|
|
notification.NotifyDeleteIssue(ctx, doer, issue)
|
2022-03-01 00:20:15 +00:00
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-10-25 14:46:37 +00:00
|
|
|
// AddAssigneeIfNotAssigned adds an assignee only if he isn't already assigned to the issue.
|
|
|
|
// Also checks for access of assigned user
|
2023-08-10 02:39:21 +00:00
|
|
|
func AddAssigneeIfNotAssigned(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, assigneeID int64, notify bool) (comment *issues_model.Comment, err error) {
|
2023-04-14 18:18:28 +00:00
|
|
|
assignee, err := user_model.GetUserByID(ctx, assigneeID)
|
2019-10-25 14:46:37 +00:00
|
|
|
if err != nil {
|
2023-08-10 02:39:21 +00:00
|
|
|
return nil, err
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Check if the user is already assigned
|
2023-04-14 18:18:28 +00:00
|
|
|
isAssigned, err := issues_model.IsUserAssignedToIssue(ctx, issue, assignee)
|
2019-10-25 14:46:37 +00:00
|
|
|
if err != nil {
|
2023-08-10 02:39:21 +00:00
|
|
|
return nil, err
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
|
|
|
if isAssigned {
|
|
|
|
// nothing to to
|
2023-08-10 02:39:21 +00:00
|
|
|
return nil, nil
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
|
|
|
|
2023-04-14 18:18:28 +00:00
|
|
|
valid, err := access_model.CanBeAssigned(ctx, assignee, issue.Repo, issue.IsPull)
|
2019-10-25 14:46:37 +00:00
|
|
|
if err != nil {
|
2023-08-10 02:39:21 +00:00
|
|
|
return nil, err
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
|
|
|
if !valid {
|
2023-08-10 02:39:21 +00:00
|
|
|
return nil, repo_model.ErrUserDoesNotHaveAccessToRepo{UserID: assigneeID, RepoName: issue.Repo.Name}
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
|
|
|
|
2023-08-10 02:39:21 +00:00
|
|
|
if notify {
|
|
|
|
_, comment, err = ToggleAssigneeWithNotify(ctx, issue, doer, assigneeID)
|
|
|
|
return comment, err
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
2023-08-10 02:39:21 +00:00
|
|
|
_, comment, err = issues_model.ToggleIssueAssignee(ctx, issue, doer, assigneeID)
|
|
|
|
return comment, err
|
2019-10-25 14:46:37 +00:00
|
|
|
}
|
2020-05-14 22:55:43 +00:00
|
|
|
|
|
|
|
// GetRefEndNamesAndURLs retrieves the ref end names (e.g. refs/heads/branch-name -> branch-name)
|
|
|
|
// and their respective URLs.
|
2022-06-13 09:37:59 +00:00
|
|
|
func GetRefEndNamesAndURLs(issues []*issues_model.Issue, repoLink string) (map[int64]string, map[int64]string) {
|
2022-01-20 17:46:10 +00:00
|
|
|
issueRefEndNames := make(map[int64]string, len(issues))
|
|
|
|
issueRefURLs := make(map[int64]string, len(issues))
|
2020-05-14 22:55:43 +00:00
|
|
|
for _, issue := range issues {
|
|
|
|
if issue.Ref != "" {
|
2023-05-26 01:04:48 +00:00
|
|
|
issueRefEndNames[issue.ID] = git.RefName(issue.Ref).ShortName()
|
2022-11-22 12:58:49 +00:00
|
|
|
issueRefURLs[issue.ID] = git.RefURL(repoLink, issue.Ref)
|
2020-05-14 22:55:43 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return issueRefEndNames, issueRefURLs
|
|
|
|
}
|
2022-06-13 09:37:59 +00:00
|
|
|
|
|
|
|
// deleteIssue deletes the issue
|
2023-04-14 18:18:28 +00:00
|
|
|
func deleteIssue(ctx context.Context, issue *issues_model.Issue) error {
|
|
|
|
ctx, committer, err := db.TxContext(ctx)
|
2022-06-13 09:37:59 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer committer.Close()
|
|
|
|
|
|
|
|
e := db.GetEngine(ctx)
|
|
|
|
if _, err := e.ID(issue.ID).NoAutoCondition().Delete(issue); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2022-12-06 07:53:09 +00:00
|
|
|
// update the total issue numbers
|
|
|
|
if err := repo_model.UpdateRepoIssueNumbers(ctx, issue.RepoID, issue.IsPull, false); err != nil {
|
2022-06-13 09:37:59 +00:00
|
|
|
return err
|
|
|
|
}
|
2022-12-06 07:53:09 +00:00
|
|
|
// if the issue is closed, update the closed issue numbers
|
|
|
|
if issue.IsClosed {
|
|
|
|
if err := repo_model.UpdateRepoIssueNumbers(ctx, issue.RepoID, issue.IsPull, true); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
2022-06-13 09:37:59 +00:00
|
|
|
|
2022-10-22 15:08:10 +00:00
|
|
|
if err := issues_model.UpdateMilestoneCounters(ctx, issue.MilestoneID); err != nil {
|
|
|
|
return fmt.Errorf("error updating counters for milestone id %d: %w",
|
|
|
|
issue.MilestoneID, err)
|
|
|
|
}
|
|
|
|
|
2023-08-07 10:23:59 +00:00
|
|
|
if err := activities_model.DeleteIssueActions(ctx, issue.RepoID, issue.ID, issue.Index); err != nil {
|
2022-06-13 09:37:59 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// find attachments related to this issue and remove them
|
|
|
|
if err := issue.LoadAttributes(ctx); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
for i := range issue.Attachments {
|
2022-10-16 23:29:26 +00:00
|
|
|
system_model.RemoveStorageWithNotice(ctx, storage.Attachments, "Delete issue attachment", issue.Attachments[i].RelativePath())
|
2022-06-13 09:37:59 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// delete all database data still assigned to this issue
|
|
|
|
if err := issues_model.DeleteInIssue(ctx, issue.ID,
|
|
|
|
&issues_model.ContentHistory{},
|
|
|
|
&issues_model.Comment{},
|
|
|
|
&issues_model.IssueLabel{},
|
|
|
|
&issues_model.IssueDependency{},
|
|
|
|
&issues_model.IssueAssignees{},
|
|
|
|
&issues_model.IssueUser{},
|
2022-08-25 02:31:57 +00:00
|
|
|
&activities_model.Notification{},
|
2022-06-13 09:37:59 +00:00
|
|
|
&issues_model.Reaction{},
|
|
|
|
&issues_model.IssueWatch{},
|
|
|
|
&issues_model.Stopwatch{},
|
|
|
|
&issues_model.TrackedTime{},
|
|
|
|
&project_model.ProjectIssue{},
|
|
|
|
&repo_model.Attachment{},
|
|
|
|
&issues_model.PullRequest{},
|
|
|
|
); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// References to this issue in other issues
|
|
|
|
if _, err := db.DeleteByBean(ctx, &issues_model.Comment{
|
|
|
|
RefIssueID: issue.ID,
|
|
|
|
}); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Delete dependencies for issues in other repositories
|
|
|
|
if _, err := db.DeleteByBean(ctx, &issues_model.IssueDependency{
|
|
|
|
DependencyID: issue.ID,
|
|
|
|
}); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// delete from dependent issues
|
|
|
|
if _, err := db.DeleteByBean(ctx, &issues_model.Comment{
|
|
|
|
DependentIssueID: issue.ID,
|
|
|
|
}); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return committer.Commit()
|
|
|
|
}
|
[FEAT] allow setting the update date on issues and comments
This field adds the possibility to set the update date when modifying
an issue through the API.
A 'NoAutoDate' in-memory field is added in the Issue struct.
If the update_at field is set, NoAutoDate is set to true and the
Issue's UpdatedUnix field is filled.
That information is passed down to the functions that actually updates
the database, which have been modified to not auto update dates if
requested.
A guard is added to the 'EditIssue' API call, to checks that the
udpate_at date is between the issue's creation date and the current
date (to avoid 'malicious' changes). It also limits the new feature
to project's owners and admins.
(cherry picked from commit c524d33402c76bc4cccea2806f289e08a009baae)
Add a SetIssueUpdateDate() function in services/issue.go
That function is used by some API calls to set the NoAutoDate and
UpdatedUnix fields of an Issue if an updated_at date is provided.
(cherry picked from commit f061caa6555e0c9e922ee1e73dd2e4337360e9fe)
Add an updated_at field to the API calls related to Issue's Labels.
The update date is applied to the issue's comment created to inform
about the modification of the issue's labels.
(cherry picked from commit ea36cf80f58f0ab20c565a8f5d063b90fd741f97)
Add an updated_at field to the API call for issue's attachment creation
The update date is applied to the issue's comment created to inform
about the modification of the issue's content, and is set as the
asset creation date.
(cherry picked from commit 96150971ca31b97e97e84d5f5eb95a177cc44e2e)
Checking Issue changes, with and without providing an updated_at date
Those unit tests are added:
- TestAPIEditIssueWithAutoDate
- TestAPIEditIssueWithNoAutoDate
- TestAPIAddIssueLabelsWithAutoDate
- TestAPIAddIssueLabelsWithNoAutoDate
- TestAPICreateIssueAttachmentWithAutoDate
- TestAPICreateIssueAttachmentWithNoAutoDate
(cherry picked from commit 4926a5d7a28581003545256632213bf4136b193d)
Add an updated_at field to the API call for issue's comment creation
The update date is used as the comment creation date, and is applied to
the issue as the update creation date.
(cherry picked from commit 76c8faecdc6cba48ca4fe07d1a916d1f1a4b37b4)
Add an updated_at field to the API call for issue's comment edition
The update date is used as the comment update date, and is applied to
the issue as an update date.
(cherry picked from commit cf787ad7fdb8e6273fdc35d7b5cc164b400207e9)
Add an updated_at field to the API call for comment's attachment creation
The update date is applied to the comment, and is set as the asset
creation date.
(cherry picked from commit 1e4ff424d39db7a4256cd9abf9c58b8d3e1b5c14)
Checking Comment changes, with and without providing an updated_at date
Those unit tests are added:
- TestAPICreateCommentWithAutoDate
- TestAPICreateCommentWithNoAutoDate
- TestAPIEditCommentWithAutoDate
- TestAPIEditCommentWithNoAutoDate
- TestAPICreateCommentAttachmentWithAutoDate
- TestAPICreateCommentAttachmentWithNoAutoDate
(cherry picked from commit da932152f1deb3039a399516a51c8b6757059c91)
Pettier code to set the update time of comments
Now uses sess.AllCols().NoAutoToime().SetExpr("updated_unix", ...)
XORM is smart enough to compose one single SQL UPDATE which all
columns + updated_unix.
(cherry picked from commit 1f6a42808dd739c0c2e49e6b7ae2967f120f43c2)
Issue edition: Keep the max of the milestone and issue update dates.
When editing an issue via the API, an updated_at date can be provided.
If the EditIssue call changes the issue's milestone, the milestone's
update date is to be changed accordingly, but only with a greater
value.
This ensures that a milestone's update date is the max of all issue's
update dates.
(cherry picked from commit 8f22ea182e6b49e933dc6534040160dd739ff18a)
Rewrite the 'AutoDate' tests using subtests
Also add a test to check the permissions to set a date, and a test
to check update dates on milestones.
The tests related to 'AutoDate' are:
- TestAPIEditIssueAutoDate
- TestAPIAddIssueLabelsAutoDate
- TestAPIEditIssueMilestoneAutoDate
- TestAPICreateIssueAttachmentAutoDate
- TestAPICreateCommentAutoDate
- TestAPIEditCommentWithDate
- TestAPICreateCommentAttachmentAutoDate
(cherry picked from commit 961fd13c551b3e50040acb7c914a00ead92de63f)
2023-05-30 16:42:58 +00:00
|
|
|
|
|
|
|
// Set the UpdatedUnix date and the NoAutoTime field of an Issue if a non
|
|
|
|
// nil 'updated' time is provided
|
|
|
|
//
|
|
|
|
// In order to set a specific update time, the DB will be updated with
|
|
|
|
// NoAutoTime(). A 'NoAutoTime' boolean field in the Issue struct is used to
|
|
|
|
// propagate down to the DB update calls the will to apply autoupdate or not.
|
|
|
|
func SetIssueUpdateDate(ctx context.Context, issue *issues_model.Issue, updated *time.Time, doer *user_model.User) error {
|
|
|
|
issue.NoAutoTime = false
|
|
|
|
if updated == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := issue.LoadRepo(ctx); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check if the poster is allowed to set an update date
|
|
|
|
perm, err := access_model.GetUserRepoPermission(ctx, issue.Repo, doer)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if !perm.IsAdmin() && !perm.IsOwner() {
|
|
|
|
return fmt.Errorf("user needs to have admin or owner right")
|
|
|
|
}
|
|
|
|
|
|
|
|
// A simple guard against potential inconsistent calls
|
|
|
|
updatedUnix := timeutil.TimeStamp(updated.Unix())
|
|
|
|
if updatedUnix < issue.CreatedUnix || updatedUnix > timeutil.TimeStampNow() {
|
|
|
|
return fmt.Errorf("unallowed update date")
|
|
|
|
}
|
|
|
|
|
|
|
|
issue.UpdatedUnix = updatedUnix
|
|
|
|
issue.NoAutoTime = true
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|